Change tab order in save dialog to be more like the wikitext editor's save form


Article Images

Dcoetzee at en.wp reports that the tab order differs in different browsers, and that at a certain point in firefox the focus gets stuck and neither tab nor shift-tab can move it.

The full comment is below:

"On Chrome Version 28.0.1500.95 m on Windows 7 x64: It starts in the edit summary field, goes to the "minor edit" link (not the checkbox), then the Save page button, then the Review your changes button (moving right to left), then the three links in the small text at the bottom, then the address bar, then the Search box, then the minor edit checkbox, then the "Interactions" menu drop down on the left sidebar (???), then the Watch this page checkbox. If I use SHIFT+TAB it goes to Edit summary link, then jumps straight to the Mediawiki logo way in the bottom right.

On Firefox 22.0 and 23.0 on Windows 7 x64: It starts in the edit summary field, goes to the "minor edit" link (not the checkbox), then the Save page button, then thereafter neither TAB nor SHIFT+TAB do anything (focus is stuck - this is a serious problem as it may require reloading the page and losing edits). SHIFT+TAB is same as in Chrome.

Conventionally, tab order is supposed to go in a logical reading order: left-to-right, top-to-bottom. My expected order was something like this:

Starts in edit summary field, goes to minor edit checkbox, then minor edit link, then Watch this page checkbox, then Review your changes button, then Save page button, then the three links at the bottom. If I use SHIFT+TAB to tab backwards, I expect to visit the Edit summary link, then (if possible) the arrow to collapse/abort the Save, then the Search box."