⚓ T65655 SettingsArray throws on HHVM if settings are set to null


Article Images

Maniphest T65655

SettingsArray throws on HHVM if settings are set to null

Closed, ResolvedPublic

Description

Caused by https://github.com/facebook/hhvm/issues/2181

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=1 s=2014-04-01

Details

Reference
bz63655

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:22 AM

• bzimport set Reference to bz63655.

• bzimport added a subscriber: Unknown Object (MLST).

hoo created this task.Apr 7 2014, 10:21 PM

Change 124480 had a related patch set uploaded by Hoo man:
Check for array_key_exists in SettingsArray before throwing

https://gerrit.wikimedia.org/r/124480

Change 124480 merged by Addshore:
Check for array_key_exists in SettingsArray before throwing

https://gerrit.wikimedia.org/r/124480

ori added a comment.Apr 8 2014, 9:06 AM

Patch for HHVM submitted upstream: https://github.com/facebook/hhvm/pull/2361.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits