⚓ T335371 Add RTL support on dialog transitions
Add RTL support on dialog transitions
Add RTL support on dialog transitions
Transitions between steps in the Vue Onboarding dialog are not adapting to directional changes in RTL
Event Timeline
Change 912774 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):
[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add RTL support to transitions in OnboardingDialog
Sgs changed the task status from Open to In Progress.May 15 2023, 10:08 AM
Sgs added a comment.EditedMay 15 2023, 10:26 AM
Looking at the latest demo there seems to be something off in the paginator text. cc @VYanez-WMF
Maybe we could add the translations from some RTL language like Arabic to make the demos more realistic and help us testing.
Sgs changed the task status from In Progress to Open.May 15 2023, 10:27 AM
Yes, noticed that. I wonder if it is related to the character directionality strong, weak or neutral types because if using a RTL lang it seems to be showing the correct direction, so I am not sure which changes we should introduce.
Sgs closed this task as Resolved.May 16 2023, 10:48 AM
Ops, you are right, this shouldn't happen in MW production.
Sgs reopened this task as Open.May 22 2023, 9:24 AM
Change 922824 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: refactor RTL handling in MultiPane to reuse codex composable
Sgs changed the task status from Open to In Progress.May 24 2023, 1:05 PM
Sgs claimed this task.
Sgs closed this task as Resolved.Jul 7 2023, 10:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits