♟ scblr

scblr renamed T374067: Design Wikipedia Year in Review main flow and actions from Design Wikiwrapped main flow and actions to Design Wikipedia Year in Review main flow and actions.

Looks good @Mazevedo – maybe we could use the heart.slash.fill symbol for this specific case:

Great work and no surprises here; it is implemented as discussed regarding back behavior and labeling. We can think/talk about removing the "Back" label app-wide in the future.

All looks good to me @GOlson-WMF – great work

question to keep the Figma library in sync with the code: does that mean we have an additional group now?

@scblr The old chrome references were updated as well by @GOlson-WMF to show grey650 for dark and black themes, so we still only have one chrome group.

Looks good to me @GOlson-WMF, thanks!

Thanks for checking @GOlson-WMF; that is fine then – I’m moving it to the next column.

Works and looks good to me @Tsevener. Moving to the next column.

It works and looks good to me @Tsevener

Thanks @GOlson-WMF – the new colors look perfect now!

scblr attached a referenced file: F57524210: image-2.png.

scblr attached a referenced file: F57524211: image-3.png.

This is challenging to test since the links in the profile view (including Settings) aren’t working yet @Tsevener.

Hey @GOlson-WMF do both of these icons use the exact size/width definition? I’m asking because the outlines of the profile icons look thicker. Thanks for clarifying.

This is challenging to test as the work hasn’t been completed yet (e.g., I can’t access Settings since the links in the profile panel aren’t working yet)

Great work so far @GOlson-WMF 👏

Because this task uses the existing warning messages designs, I think this should move forward,

What about this suggestion @HNordeenWMF? 👇

Thanks for all the info @Tsevener. In general: I feel like toasts/snackbars are not very native to the platform. But yeah, let's decide which of the three we’re moving forward with without any rewriting, so we’re at least consistent from now on. I added it to our agenda for our 1:1 tomorrow!

@scblr after talking with @KColeman-WMF, the Temporary account label should be replaced with the temporary account ID

• True @Tsevener – a clear button would suffice from a design perspective.
• In addition, we could hide the donation history button when there’s no local donation history (to spare the empty state design/implementation) [CC @Mazevedo]

Sounds good @Tsevener – I created T374607.

Thanks, @Tsevener – I love this change. I suggest aligning this work with the navigation profile view, which uses inset lists, too (T373714):

If both "Back" and "Explore" are taking you back to the Explore tab (without the open modal/sheet) in your example, displaying "Explore" feels completely natural.

Yeah both "Back" and "Explore" would take you back to the Explore tab without the open modal /sheet. So I'm good with the more specific phrasing if you are.

Thanks, @Tsevener – seeing it now!

Hi @scblr!

Thanks for taking a look at that. For your items:

1. Yes! We can create this in a component-y way so that we can reuse it in the future. What do you think?

@Tsevener I tried this in 7.5.9 (158) on iOS 18 Beta multiple times, but it didn’t show, see this recording. Am I missing something? Thanks!

Thanks, @Mazevedo – this looks good so far.

Thanks for the work on this @cmadeo 👏

I think part of the reason this came up is that we will not be able to display "Profile" as the back button when the user selects an option from the Profile menu, because we will need to dismiss profile before navigating away to get out of the page sheet context.

I just played around with it on iPad Mini @GOlson-WMF. It works and feels good to me. Thanks!

Looks good to me, thanks @Tsevener

Quick feedback on this @HNordeenWMF. We should always name the origin (title of the previous screen) rather than using the word Back. It’ll indicate to users where they’re going back.

@GOlson-WMF are there any ux related changes for this one? If not please move it to the next column. Thanks!

It works and looks perfect, @GOlson-WMF – thanks for the work on this! 👏

1) [minor] Positioning of the tooltip: Can it be moved up a tad (top left) according to design specs?

Ok thx, @HNordeenWMF – I reviewed it based on your screenshot.

As this is minor feedback re: language – I’m moving this to Needs Code Review

I haven’t managed to trigger the dialogs for Flow C yet – I tried it via random edit on test wiki (per @HNordeenWMF ’s input) and an image upload via wikitext (per @Mazevedo’s input).

Toast looks good to me now @Tsevener 👍

Toast looks good to me now @Mazevedo 👍

Hey @HNordeenWMF, this is completed from my end. Here’s the analysis, including answers to the research questions.

I tested it again @Tsevener – the survey/form looks good, but the feedback toast ("Feedback submitted") isn’t visible yet.

@Tsevener I don’t see 150 in the list:

Hey @Mazevedo – is this round of review only about the flow B dialog? If yes – it looks good to me:

I'm following the copy from the translation sheet. If I used the one in the designs, it wouldn't match the translations. For the extra space, I can remove it in the next task.

The only difference is the contents/length of the licensing information. Not quite sure what’s been decided here @Tsevener / @HNordeenWMF?

Works and looks as specified. Thanks @Tsevener 👏

Works well and looks good @Tsevener, great work!

Thanks @Mazevedo for the work on this 👏 I experienced this when trying it out:

Pasting does not work in the Describe the image field

That's by design - task description says "Nice to have: Input box does not allow pasting into it (to avoid users copy/pasting the caption)"

scblr renamed T372400: Improve design "Add alt text" view from Improve design of add alt text "Add alt text" view to Improve design "Add alt text" view.

Thanks @Tsevener. The new developer setting is super helpful!