VisualEditor


Article Images

Description

VisualEditor is a project to create a reliable, full-featured rich-text or "visual" HTML editor for the Web. Though VisualEditor itself is an HTML editor, it is integrated into platforms for use there, primary in MediaWiki-General with the VisualEditor-MediaWiki integration, used in conjunction with the Parsoid parsing service to provide the HTML+RDFa.

Our projects are arranged as follows:

  • VisualEditor – Anything related to VisualEditor, including related extensions.

Change #1077757 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Disable unused icon variants

https://gerrit.wikimedia.org/r/1077757

Web team will follow up on this in T374145 which I've added a parent task. Leaving open for testing purposes when we get the fix applied.

Change #1077757 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Disable unused icon variants

https://gerrit.wikimedia.org/r/1077757

There are also issues in the mobile editor:

image.png (221×294 px, 11 KB)

Change #1077398 abandoned by Esanders:

[mediawiki/core@master] OOUIImageModule: Disable mask-image for OOUI icons

https://gerrit.wikimedia.org/r/1077398

Per what @MNeisler and I talked about offline, we think a discussion with David, Marielle, Megan, and me is a good next step to resolve the discrepancy between what Megan discovered in T374624#10158451 and what Marielle discovered in T372438#10191087.

Notes @DLynch shared offline:

  • This ticket is useful to making it possible for volunteers to review individual edits based on the specific Edit Check(s) shown within it
  • This ticket is NOT useful to creating a higher-level dashboard that would enable the Editing Team to monitor the Edit Check system at a higher level (
    • % of edits an Edit Check is activated within
    • Revert rate of edits any Edit Check is activated within
    • Edit completion rate of edits any Edit Check is activated within
    • etc.

Which is to say: if citoid is returning an API error when we encounter a non-200 status code, all of that should get swept into the network category.

Looking at how it was done...

Thanks @MNeisler. I'm a little confused by the language "network error" and "no results" with network error being 20%, with no results being so low. From the service end of things, ~20% is the right percentage of "no results found" - I don't see how that would translate into such a tiny percentage? What does "network error" and "no results" here mean in terms of status codes?

Change #1077398 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] OOUIImageModule: Disable mask-image for OOUI icons

https://gerrit.wikimedia.org/r/1077398

Looks like the mask-image property is being set, which seems unnecessary for an OOUI icon...

@egardner +1

then link styles should be scoped to mw-content or parser output somehow

content-embedded UI components complicate this a bit, but scoping to parser output will limit the side effects to a smaller subset of features.

then link styles should be scoped to mw-content or parser output somehow

Just pressing Enter in the edit summary field saves the page in the 2010 editor.

It's now sorted alphabetically anyway. I guess that patch (which I never was convinced was a good idea anyway) should be reverted.

I love it when we discover new and incompatible wikitext parsers.

Change #1077100 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Document the significance of the entries returned by InterwikiLookup

https://gerrit.wikimedia.org/r/1077100

Wrote two patches (core, Parsoid) to document this behavior.

Change #1077099 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Document signifiance of array order for SiteConfig::interwikiMap()

https://gerrit.wikimedia.org/r/1077099

Looked into this. Parsoid matches the interwiki prefix with this code with SiteConfig::interwikiMatcher() which iterates over SiteConfig::interwikiMapNoNamespaces() and uses the first match. (Technically it creates a regexp along the way so this also relies on the fact that regexp | alternations are also matched left-to-right.) ::interwikiMapNoNamespaces() is created from SiteConfig::interwikiMap(), still preserving order.