VisualEditor-MediaWiki-Mobile


Article Images

Description

VisualEditor bugs and enhancements specifically for mobile devices (phones, tablets etc.) as made in the VisualEditor-MediaWiki integration.

Reminder: All VisualEditor-related tasks should be tagged with VisualEditor as well, for tracking, triage and management purposes.

Aug 23 2024, 8:44 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

I cannot reproduce this bug on various beta sites, various devices, new and existing articles.

Verified.

Aug 20 2024, 4:01 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Change #1063828 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Temp user creation: stop VE and EditorOverlayBase from both redirecting

https://gerrit.wikimedia.org/r/1063828

Aug 20 2024, 3:25 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

This is in QA on two team's boards, but I think it only needs to be done by one team's QA (whoever gets to it first?)

Aug 20 2024, 3:21 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 20 2024, 3:21 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 20 2024, 3:21 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 20 2024, 3:08 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 20 2024, 3:08 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 19 2024, 3:07 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Change #1063828 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/MobileFrontend@master] Temp user creation: stop VE and EditorOverlayBase from both redirecting

https://gerrit.wikimedia.org/r/1063828

If it's mobile-only, it's simpler than @matmarex was worried about, because DesktopArticleTarget isn't in the picture. Instead, EditorOverlayBase.onSaveComplete in MobileFrontend and ArticleTarget.saveComplete in VE are stepping on each other's toes and both doing a redirect uncritically. It used to not matter very much, because ArticleTarget only redirected on new-page-creation, and a double-redirect there wasn't awful, but now there's this new condition...

Aug 19 2024, 10:53 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

kostajh renamed T370747: "The provided authentication token is either expired or invalid" when editing a temporary accounts wiki with mobile VisualEditor as an anon user from "The provided authentication token is either expired or invalid" when editing a temporary accounts wiki on mobile as an anon user to "The provided authentication token is either expired or invalid" when editing a temporary accounts wiki with mobile VisualEditor as an anon user.

Aug 5 2024, 10:01 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 5 2024, 9:55 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Aug 5 2024, 9:54 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Maybe the code in VisualEditor that does location.href = ... to perform the redirect runs twice somehow? It's a bit gnarly with a bunch of callbacks jumping between DesktopArticleTarget and ArticleTarget.

Jul 30 2024, 2:57 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Jul 25 2024, 12:13 PM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Jul 25 2024, 9:46 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

So yeah there are two start requests (I assume that's Special:CentralLogin/start on loginwiki), with the first cancelled (but probably still reaching the servers). Given this only happens in VisualEditor, probably an issue there?

image.png (326×1 px, 79 KB)

Here are the requests I see. The api.php request is the one to post the VisualEditor edit. The 604504 request is a failed attempt to save client hints.

Here are the requests I see. The api.php request is the one to post the VisualEditor edit. The 604504 request is a failed attempt to save client hints.

Token store expiry is one minute so that seems unlikely. The central login code tries for up to three seconds to read the store, so it's probably not replication lag either. At this point no cross-domain cookies are involved (this is step 4 of T363699#9980913 failing) so I can't see a way of browser privacy limitations being relevant. The data is deleted from the token store once retrieved, so my guess would be the URL is somehow accessed twice. (Some kind of preloading, maybe?) If you can reliably reproduce the issue, maybe you can verify that via the webrequest table?

I can reproduce this on Chrome and Firefox when using https://test.m.wikipedia.org.

I notice that after publishing on desktop VE as an anon user I am returned to the page but the new edit does not show and I am still shown as logged out (even though an account has been created in the background). I don't know if this is related. So far, I have only reproduced this on https://test.wikipedia.org on Firefox.

Jul 23 2024, 8:29 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Jul 23 2024, 8:00 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

I was able to make an edit successfully using Firefox (on desktop) in private browsing mode on test.m.wikipedia.org and stay logged in as a temp account. When I tried in private browsing mode on Safari iOS, I see the same error noted in the task description.

Jul 23 2024, 7:51 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

Jul 23 2024, 7:50 AM · Verified, MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)), Editing-team (Kanban Board), Patch-For-Review, Temporary accounts (Blockers to minor pilot wiki deployment), MediaWiki-Platform-Team (Radar), VisualEditor, MediaWiki-extensions-CentralAuth, VisualEditor-MediaWiki-Mobile, MobileFrontend, Trust and Safety Product Team

This appears to be an unused placeholder ticket from 5 years ago. Please feel free to reopen it in case you still need it.

I couldn't reproduce this in my local environment, but it was still happening on live. The only difference I could see was the "Open in the Wikipedia App" bar I had because the app was installed. I uninstalled the app and the problem went away...

Change 1008961 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] VE: Transition margin instead of padding on new codex icon

https://gerrit.wikimedia.org/r/1008961