⚓ T277883 Drop all low-use and unused features of FlaggedRevs to make it more maintainable
Article Images
Drop all low-use and unused features of FlaggedRevs to make it more maintainable
Drop all low-use and unused features of FlaggedRevs to make it more maintainable
Split from parent per @Tgr.
- Drop flagging features
- Drop having multiple tiers of review
- Drop tier3 (pristine) support – rEFLR41d295479e16: Drop tier3 (pristine) support
- Drop tier2 (quality) support – rEFLR04ffb5f56f23: Drop quality tier
- Clean-up now there's only one tier
- Drop having multiple dimensions of review ("tone", "style", etc.)
- Drop "tone" and "style" dimensions – rEFLRddb91cf8b29a: Drop depth and style from tag types
- Support only one dimension – rEFLR3fe0bacc5bb3: Support only one dimension
- Standardize the dimension name (the key in $wgFlaggedRevsTags) across all wikis
- Drop ability to have pages immune from review – rEFLR0fe4ed9a6842: Drop FlaggedRevsWhitelist option and just disable it on main page
- Drop ability to show the version of templates/files that the page used when reviewed – rEFLRe4ff4779203d: Drop FR_INCLUDES_FREEZE
- …
- Drop having multiple tiers of review
- Drop UX features
- Special pages:
- ProblemChanges – rEFLR8d8b3822d3ac: Drop ProblemChanges special page
- ReviewedPages – rEFLR7de102e939d5: Drop Special:ReviewedPages
- ReviewedVersions – rEFLR552aaf00394b: Drop Special:ReviewedVersions (and API equivalent, rEFLRdc93e33eb3a7: Drop ApiQueryReviewedpages)
- AdvancedReviewLog (aka QualityOversight) – rEFLR9aed5fdd91f1: Drop Special:AdvancedReviewLog (a.k.a. Special:QualityOversight)
- Drop ability to choose which user groups get shown unreviewed versions by default – rEFLR50ffcdf7ca93: Drop wgFlaggedRevsExceptions option
- Drop background image on non-low profile wikis when a page has a pending edit you're not seeing – rEFLR889ee09d2e91: Clean up two barely used frontend features
- Drop hidden message on non-simple UI wikis when viewing an old stable revision as a a reviewer – rEFLR889ee09d2e91: Clean up two barely used frontend features
- T285608: Stop logging and clean up auto review logs
- …
- Special pages:
- Drop extension hooks
- Drop FlaggedRevsFRGenericSubmitFormReady hook – rEFLRe894afbca50b: Drop FlaggedRevsFRGenericSubmitFormReady hook
- Drop FlaggedRevsRevisionReviewFormAfterDoSubmit Hook – I0d73aa07ad247ca37318ff0251a003484739a25c
- …
- Merge user rights
- Remove not user-facing methods and classes unused after the above removals
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Note that this is not stalled. I have been cleaning up its useless data in production but there are just so much of them. Already over 1TB of clean up now.
Change 678136 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/FlaggedRevs@master] Cleanups after removing extra tiers and extra dimensions
Reason:
I checked and it looks like all this was already done as part of other patches. Sorry, I somehow missed this one here.
Mentioned in SAL (#wikimedia-operations) [2023-03-09T14:55:52Z] <zabe@deploy2002> awight and zabe: Backport for [[gerrit:790707|Drop unused FlaggedRevs threshold level names (T277883)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet
We cut the size of this extension to half. Sure more can be done but I don't see any obvious removals anymore.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits