⚓ T334661 rdbms: Find a way to use IDatabase::unionConditionPermutations without raw SQL
Maniphest T334661
- Edit Task
- Edit Related Tasks...
- Edit Related Objects...
- Mute Notifications
- Protect as security issue
- Award Token
- Flag For Later
Assigned To
Authored By
| Umherirrender | |
| Apr 13 2023, 10:48 AM |
Tags
Referenced Files
None
Subscribers
Description
Description
The use of IDatabase::unionConditionPermutations results in use of raw sql via IDatabase::query and needs a replacement.
Maybe the new UnionQueryBuilder (T333690) can take care of this permutation condition.
Details
Details
Related Objects
Related Objects
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Ladsgroup | T343098 [epic] Data Persistence Hypothesis WE 3.2.1 | |||
| Open | Ladsgroup | T210206 Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) | |||
| Resolved | Ladsgroup | T334661 rdbms: Find a way to use IDatabase::unionConditionPermutations without raw SQL |
Event Timeline
Umherirrender created this task.Apr 13 2023, 10:48 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptApr 13 2023, 10:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a parent task: T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.).Apr 13 2023, 10:48 AM
Ladsgroup subscribed.Apr 13 2023, 11:03 AM
It's only used in Special:ShortPages, I honestly think we probably should get rid of it. From a glance it should be possible to refactor it to avoid it but maybe I'm missing something
Umherirrender added a comment.EditedApr 13 2023, 11:26 AM
Ladsgroup added a comment.Apr 13 2023, 4:20 PM
I read it and honestly it doesn't justify a dedicated and complex method like this. Specially given the fact that we are moving away from arrays as "query"s
larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Apr 17 2023, 6:30 PM
larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.
Ladsgroup mentioned this in T335100: Warning: SQLPlatform::isWriteQuery fallback to regex (SpecialShortPages).Apr 20 2023, 11:12 AM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.May 8 2023, 6:16 PM
gerritbot added a comment.Jun 2 2023, 4:30 PM
Change 926570 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[mediawiki/core@master] Completely get rid of Database::unionConditionPermutations()
gerritbot added a project: Patch-For-Review.Jun 2 2023, 4:31 PM
gerritbot added a comment.Jun 5 2023, 8:03 PM
Change 927258 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] SpecialShortPages: Document reason for "reallyDoQuery" override
gerritbot added a comment.Jun 5 2023, 8:15 PM
Change 926570 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Remove Database::unionConditionPermutations() and callers
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 5 2023, 9:00 PM
Ladsgroup closed this task as Resolved.Jun 6 2023, 6:14 AM
Ladsgroup claimed this task.
Ladsgroup edited projects, added DBA; removed Patch-For-Review.
gerritbot added a comment.Jun 6 2023, 6:27 AM
Change 927258 merged by jenkins-bot:
[mediawiki/core@master] SpecialShortPages: Document reason for "reallyDoQuery" override
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.13; 2023-06-13); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 6 2023, 7:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits